npmignore cleanup; adding some types to Client #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdevel
requested changes
Feb 22, 2019
There was a problem hiding this comment.
@andygreenegrass not sure how i feel about the example code. we already have plenty of sample WSDLs and projects under test/. i'd rather have that removed from this pr. the rest i'm fine with.
|
That's fair. examples removed. |
andygreenegrass
changed the title
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added examples - I personally find example code to be helpful in terms of getting up and running with a new library. I also think it gives the library developer an opportunity to define best practices since it will be copy/pasted by everyone.
Added
/docsto.npmignore- I think ultimately the project should use an npm white list.It looks like the
last*properties ofClientshould be public so I changed that.