Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools version setup/requirement #25

Open
jongb opened this issue Nov 30, 2017 · 2 comments
Open

Tools version setup/requirement #25

jongb opened this issue Nov 30, 2017 · 2 comments

Comments

@jongb
Copy link

jongb commented Nov 30, 2017

Hi,

The README, and package.json, should include a version setup or requirement.
Or at least a tested local setup.
There seems to be a lot of global issues with NPM, React and libs these days.

npm/npm#17858
mapbox/node-pre-gyp#298

These effect new developers using the latest (not so) greatest tools.

I would be happy to submit any issues I find, but a working setup would be nice to confirm my findings.

@nynevi
Copy link
Contributor

nynevi commented Jan 26, 2018

Hello,

Thank you for your interest in VQ-Marketplace. I've recently joined ranks among VQ-Labs as a developer and have made it my number one priority to refactor all the marketplace repos in a way that they run environment-agnostic (for example you cannot start the repo on windows machine because of the ENV variables being defined in package.json in Linux fashion).

You will in the coming days see a change in the README with a new way of running the applications (which will have consistent structure and naming among repos that makes it easier to work.).

We'll take your issue into account and document the tested versions in README such as NodeJS version, NPM version etc. (along with a link to NVM so that people can differentiate between projects easily).

We have sucessfully run the project on:
NodeJS 7.2.1 and NPM 3.10.9 on macOS Sierra 10.12.6,
NodeJS 8.3.0 and NPM 5.6 on Windows 10,
NodeJS 9.0.0 and NPM 5.5.1 on AWS Linux Ubuntu 16.04.2,

I believe your NPM version is 5.3 but can you be more specific on which OS, NodeJS and NPM versions you are using so we can test and avoid them (and document them in README) if necessary.

Again, thank you for your interest, we appreciate any kind of feedback. Feel free to contact us via GitHub. We will soon have a more transparent development cycle on Trello so that you can track our progress on issues being created.

@nynevi
Copy link
Contributor

nynevi commented Mar 15, 2018

@jongb Hello,

We have refactored all of our repos to be more open source friendly and wanted to make sure that your recommendation is fulfilled:

  • Added engine to package.json on all repositories
  • Added .nvmrc file for easy switch to the appropriate NodeJS version. You can switch to the one we enforced by running nvm use
  • We have improved documentation on all our repositories for easier setup

We are still evolving so there might still be few things missing here and there. We appreciate any kind of feedback and want to thank you again for your interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants