Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ResizableImageExtension to properly integrate with flexmark-java #570

Open
6 tasks
vsch opened this issue Apr 28, 2023 · 0 comments
Open
6 tasks

Comments

@vsch
Copy link
Owner

vsch commented Apr 28, 2023

Current implementation does not follow the proper inline parser extension model

One option is to integrate the =#x# syntax into the core parser, enabled via an option and mark the ResizableImageExtension as deprecated. Otherwise,

  • Change: implement ResizableImageExtension to properly integrate with flexmark-java
    extension model.
    • Change: implement proper InlineParser handling of ref based nodes.
    • Change: make ResizableImage be an extension of Image node with all the source
      elements that make up the node for tracing back to source.
    • Change: an image without resize syntax should be parsed as an Image not
      ResizableImage
    • Add: all necessary handlers to allow formatting, and html to md conversion
    • Add: tests to make sure it works in links and as reference, with proper AST generation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant