Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for other pod terminal shells in extension config file #1264

Open
roberto-sebastiano opened this issue Mar 25, 2024 · 0 comments
Open
Labels
discussion Proposal for community discussion enhancement triage

Comments

@roberto-sebastiano
Copy link

Hello,

I see that it seems there is no way of forcing the extension to use a shell different from bash when opening a terminal for a pod from the extension sidebar (Pods -> Pod Name -> Icon Terminal)

From this line, I see that we call the function isBashOnContainer, maybe we could first check if we specified the shell as an option in the extension, like

vs-kubernetes.pod-shell: "zsh"

In that case, use that as an override to "isBashOnContainer"
otherwise, we could rename isBashOnContainer to isShellOnContainer, check for vs-kubernetes.pod-shell value, if that option is missing, then check for "bash" as a fallback

Thank you,
Roberto Sebastiano

@Tatsinnit Tatsinnit added enhancement triage discussion Proposal for community discussion labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Proposal for community discussion enhancement triage
Projects
None yet
Development

No branches or pull requests

2 participants