Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint Rules: Don't warn on missing CPU limit if requests is set #1266

Open
shadiramadan opened this issue Apr 16, 2024 · 0 comments
Open

Lint Rules: Don't warn on missing CPU limit if requests is set #1266

shadiramadan opened this issue Apr 16, 2024 · 0 comments

Comments

@shadiramadan
Copy link

I will reference this post: https://home.robusta.dev/blog/stop-using-cpu-limits
Counter point: https://dnastacio.medium.com/why-you-should-keep-using-cpu-limits-on-kubernetes-60c4e50dfc61
Response: https://news.ycombinator.com/item?id=24381813

Related Issue: #408

Given there isn't exactly any agreement on this it would be nice if we could configure the linter to still warn if missing mem limits., but to ignore a missing CPU limit if CPU requests is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant