Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: highlighting breaks RTL text #1367

Closed
3 tasks done
adueck opened this issue Aug 1, 2023 · 1 comment
Closed
3 tasks done

bug: highlighting breaks RTL text #1367

adueck opened this issue Aug 1, 2023 · 1 comment
Labels
bug Something isn't working category: localisation Issues regarding language and keyboard compatibility help wanted PRs are welcome manager: highlight

Comments

@adueck
Copy link

adueck commented Aug 1, 2023

Did you check docs and existing issues?

  • I have read all the vscode-neovim docs
  • I have searched the existing issues of vscode-neovim
  • I can reproduce the issue with an empty init.vim/init.lua and no other vscode extensions (when applicable)

Neovim version (nvim -v)

0.8.3

Operating system/version

MacOS 13.0.1

Describe the bug

When using NeoVim highlighting over matching RTL text (Arabic etc.), the character ordering is broken. (This happens both while searching and while in visual mode).

Screenshot 2023-08-01 at 6 19 38 PM

Screenshot 2023-08-01 at 6 20 22 PM

One of the great things about VSCode is how it handles RTL text perfectly (including selecting). I've been delighted to be able to use NeoVim + VSCode and enjoy the RTL support as well, it would be great if this little wrinkle could be ironed out. Perhaps this is a more difficult issue though...

Steps To Reproduce

  1. Type something in RTL text
  2. Highlight part of or all of the RTL text
  3. The order of the characters is scrambled.

Expected Behavior

Just as with the VSCode native highlighting/selection, a selection should not break the RTL word order.

@adueck adueck added the bug Something isn't working label Aug 1, 2023
@theol0403 theol0403 added help wanted PRs are welcome category: localisation Issues regarding language and keyboard compatibility manager: highlight labels Sep 4, 2023
@xiyaowong
Copy link
Collaborator

image

The current highlighting is consistent with nvim. There is nothing we can do.

You can use vscode's search.

map <silent> / <Cmd>call VSCodeCall('actions.find')<CR>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working category: localisation Issues regarding language and keyboard compatibility help wanted PRs are welcome manager: highlight
Projects
None yet
Development

No branches or pull requests

3 participants