Investigation: Use language server

[timonwong]

No description provided.

[felipecrs]

@timonwong, could you elaborate?

[dseynhae]

I have been impressed with the capabilities of the LanguageServer API:

• The Perl extension makes for a very rich edit and debug experience based on the Perl::LanguageServer library (I think this library also includes the VS Code Debug Adaptor).
• The Bash IDE is a language server extension that has a similar impact on my edit-based debugging..., based on the treesiter compiler...

I don't know enough of the architecture of the Bash IDE underlying compiler, nor have I looked for the foundation of shellchecker. But it seems to me that it would be great to have a common parser underneath, and then merge the capabilities for Editing/Outlining, Error Checking/Linting, Debugging in a common effort to support the **LSP (Language Server Protocol) ** with Debug Adaptor Protocol for Bash/Shell...

However.
shellchecker currently doesn't offer rich editing nor debugging capabilities, it supplies a rich set of "problems".
I didn't think that those are covered by LSP, are they???
I think it is time for me to dig a bit deeper in the VS Code architecture, before I make a fool of myself here...

[felipecrs]

ESLint for example is delivered as a separate extension, only for lining purposes just the way this extension is.

JavaScript Debugger as well, just the way Bash Debug is.

So I still don't understand what else could be made for the ShellCheck extension that is not already covered by Bash IDE or Bash Debug.

I doubt that we should extend its functionalities beyond the original ShellCheck itself.

[dseynhae]

So I still don't understand what else could be made for the ShellCheck extension that is not already covered by Bash IDE or Bash Debug.

I guess I was too focussed on my ignorance of the architecture, and not enough on the question that I have...
Ir is the same question you stated: What can the Language Server Protocol do for shellcheck?

The LSP enhances the EDITING experience (and combined with the DAP, the DEBUGGING experience).

But VS Code also does PROBLEM REPORTING, which, as far as I know, is independent of LSP/DAP???
And I believe that shellcheck is integrated with the PROBLEM REPORTING GUI through the correct TypeScript API??

But that is where my ignorance shines... I really haven't looked into the VS Code Extensions architecture...

[felipecrs]

What can the Language Server Protocol do for shellcheck?

Now it's much more clear. That's my doubt and I'm also ignorant in this sense.

And I believe that shellcheck is integrated with the PROBLEM REPORTING GUI through the correct TypeScript API??

I can't answer this yet, but probably @timonwong can.