Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not passing all possible props to ReactDropzone #1116

Open
estacioneto opened this issue Mar 24, 2020 · 4 comments
Open

Not passing all possible props to ReactDropzone #1116

estacioneto opened this issue Mar 24, 2020 · 4 comments

Comments

@estacioneto
Copy link
Contributor

Describe the bug

That's it. I cannot be able to pass, for example, minSize and maxSize to the ReactDropzone via Styleguide.

To Reproduce

Try to use any of the ReactDropzone validations

Expected behavior

Validate minSize, maxSize and others.

Screenshots

Styleguide

image

Dropzone

image

@emersonlaurentino
Copy link
Member

When @kevinch created this component, it was just to meet the need in that context. I already needed some features that I don't have either:

  • a list of file types that are supported
  • max file size
  • event for when the file is removed

which are you currently needing @estacioneto?

@estacioneto
Copy link
Contributor Author

estacioneto commented Apr 16, 2020

There is an event for when the file is removed 🤔 (onFileReset). Anyway, I need a max file size verification (also the type checking would be great).

@emersonlaurentino
Copy link
Member

I said wrong, sorry. I meant that I need an event to remove the files. Because currently it is only possible to remove files if you click the button.

@estacioneto
Copy link
Contributor Author

It would be possible if the file list was handled outside the component. And it would be great, actually 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants