Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use size prop on AutocompleteInput #1244

Open
edenalsant opened this issue Jun 10, 2020 · 3 comments · Fixed by #1251
Open

Use size prop on AutocompleteInput #1244

edenalsant opened this issue Jun 10, 2020 · 3 comments · Fixed by #1251

Comments

@edenalsant
Copy link
Contributor

Describe the bug
In the AutocompleteInput component there's no size related prop, making harder to adjust it's size.

To Reproduce
Steps to reproduce the behavior:
With the InputSearch component it's possible to adjust it's size as it has a size props exposed.
To see the different among them
Go to this page. Here it's used the InputSearch component, whereas in this workspace it's being used the AutcompleteInput.

Expected behavior
The adjustment of the component's size being done by setting the prop

Screenshots
Production environment using InputSearch
image

Workspace using AutocompleteInput
image

@davicostalf
Copy link
Contributor

TLDR: I believe you should go ahead and add the prop.

AutocompleteInput as it exists may not make sense. Myself, @emersonlaurentino and @augustocb have discussed in the past what would be the ideal architecture for our form fields, but we still have not made any decisions.

From the design language perspective, my take is that these components make sense: https://www.figma.com/file/OXQsRsqiHNGcOmmprfM9KC8T/02-FieldSearch

We briefly discussed use cases for dropdowns in text fields and select fields. @augustocb and @emersonlaurentino may have further evolved these ideas since our last conversation.

Since you’ve found this limitation in our current implementation - that really doesn’t make sense IMHO - the short-term solution would be to fix it by adding the prop. However, a welcome addition would be to rethink what components make sense in the implementation of our design language.

@emersonlaurentino
Copy link
Member

I believe you should add the prop. Just like @davicosta99 said, we know that the current AutocompleteInput is not legal, we have an idea of ​​how to improve, but we still don't have anything concrete.

@edenalsant edenalsant self-assigned this Jun 17, 2020
@edenalsant edenalsant mentioned this issue Jun 17, 2020
4 tasks
@vlaux vlaux linked a pull request Jul 10, 2020 that will close this issue
4 tasks
@vlaux
Copy link
Member

vlaux commented Jul 10, 2020

Could this issue be closed due to #1251 already merged into master? cc @edenalsant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants