Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version 4.44.15 utilises a compromised colors package #1274

Closed
azriel46d opened this issue Feb 4, 2022 · 3 comments
Closed

Latest version 4.44.15 utilises a compromised colors package #1274

azriel46d opened this issue Feb 4, 2022 · 3 comments
Labels
stale more than 60 days without activity

Comments

@azriel46d
Copy link

azriel46d commented Feb 4, 2022

Current behavior

As soon as you bump up and clean the npm packages , the solution adopts a compromised version of colors a dependency to cli-progress
Reference: Marak/colors.js#285
To fix: bump up the version of cli-progress (npkgz/cli-progress#116)
To reproduce

  1. Bump up and install latest
  2. run npm run styleguide

Expected behavior

@DanielRuf
Copy link

DanielRuf commented Feb 5, 2022

The compromised package version was removed from npmjs many days ago. Version 1.4.0 is not affected.

Only clean versions are available. See npkgz/cli-progress@1f0c40e#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2deL238 and https://www.npmjs.com/package/colors?activeTab=versions

Nothing to worry at the moment.

cli-progress 3.9.0 and newer (includes 3.10.0, SemVer selector ^) is already used, see https://github.com/vue-styleguidist/vue-styleguidist/blob/dev/packages/vue-styleguidist/package.json#L38

This includes the automatic update to 3.10.0.

@elevatebart
Copy link
Member

It still does not hurt to update but I it is less of an emergency.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale more than 60 days without activity label Apr 16, 2022
@stale stale bot closed this as completed Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale more than 60 days without activity
Projects
None yet
Development

No branches or pull requests

3 participants