Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
fix: typos (#788)
Co-authored-by: webfansplz <>
  • Loading branch information
webfansplz committed Aug 17, 2021
1 parent 7260acc commit 59653ac
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/apis/effectScope.ts
Expand Up @@ -102,7 +102,7 @@ export function onScopeDispose(fn: () => void) {
activeEffectScope.cleanups.push(fn)
} else if (__DEV__) {
warn(
`onDispose() is called when there is no active effect scope` +
`onScopeDispose() is called when there is no active effect scope` +
` to be associated with.`
)
}
Expand Down
6 changes: 3 additions & 3 deletions test/v3/reactivity/effectScope.spec.ts
Expand Up @@ -190,7 +190,7 @@ describe('reactivity/effect/scope', () => {
expect(doubled).toBe(undefined)
})

it('should fire onDispose hook', () => {
it('should fire onScopeDispose hook', () => {
let dummy = 0

const scope = new EffectScope()
Expand All @@ -209,7 +209,7 @@ describe('reactivity/effect/scope', () => {
expect(dummy).toBe(7)
})

it('should warn onDispose() is called when there is no active effect scope', () => {
it('should warn onScopeDispose() is called when there is no active effect scope', () => {
const spy = jest.fn()
const scope = new EffectScope()
scope.run(() => {
Expand All @@ -221,7 +221,7 @@ describe('reactivity/effect/scope', () => {
onScopeDispose(spy)

expect(
'[Vue warn]: onDispose() is called when there is no active effect scope to be associated with.'
'[Vue warn]: onScopeDispose() is called when there is no active effect scope to be associated with.'
).toHaveBeenWarned()

scope.stop()
Expand Down

0 comments on commit 59653ac

Please sign in to comment.