fix(types): optional Boolean prop types #636 (#678)

vuejs · Apr 18, 2021 · a081227 · a081227
1 parent 7955e28
commit a081227
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/component/componentProps.ts b/src/component/componentProps.ts
@@ -27,7 +27,13 @@ type PropConstructor<T> =
   | { new (...args: string[]): Function }
 
 type RequiredKeys<T> = {
-  [K in keyof T]: T[K] extends { required: true } | { default: any } ? K : never
+  [K in keyof T]: T[K] extends
+    | { required: true }
+    | { default: any }
+    | BooleanConstructor
+    | { type: BooleanConstructor }
+    ? K
+    : never
 }[keyof T]
 
 type OptionalKeys<T> = Exclude<keyof T, RequiredKeys<T>>

diff --git a/test-dts/defineComponent.test-d.ts b/test-dts/defineComponent.test-d.ts
@@ -85,7 +85,6 @@ describe('with object props', () => {
       },
       hhh: {
         type: Boolean,
-        required: true,
       },
       // default + function
       ffff: {