feat: adding missing reactivity api from vue-next #311

pikax · 2020-04-19T10:04:00Z

This plugin is falling behind on the reactivity API

This PR is aimed to make the reactivity API close as possible to vue-next.

Current problems

effect not ported
readonly not ported
makeRaw this is quite cheat, since the original object gets change, having this doesn't do much
reactive([]) - because of the v2 reactivity system arrays cannot be reactive, should be warn?

Breaking

Watch effect now follows the same behaviour as v3

Added

shallowReactive
shallowRef

Changes

reactive marks all possible objects as reactive to conform to vue 3
set marks reactive

close vuejs#293

…Ref type

implementation is wrong, but it just to have something kinda working, suggestions and help is welcome :)

# Conflicts: # src/apis/state.ts # src/reactivity/index.ts # src/reactivity/ref.ts

# Conflicts: # src/apis/inject.ts # src/reactivity/ref.ts

…nt' into feat/vue3_API # Conflicts: # test/apis/watch.spec.js

Vue2 Limitations

LinusBorg · 2020-05-09T13:19:28Z

This looks like great work!

I'll need a bit more time to properly review this. I'm on it tough!

src/reactivity/reactive.ts

src/apis/watch.ts

LinusBorg · 2020-05-16T10:41:40Z

So I have done a review.

changes to reactivity look fine
tests: We now have a lot of tests where we switched to { immediate: true } (since that's how watch behaves now) and seemingly very little are left testing the now-default {immediate: true } behaviour. But we still have everything covered, I think. just feels weird to have a majority of the tests use the non-default.
Types: It's awesome that you took the extra steps and renamed everything to be in line with Vue 3, that looks like it was a lot of work and is highly apprechiated. For the really complex types that you ported from the Vue 3 codebase I can say little as they are a bit over my head for the most part 😅

So from my perspective this looks fine!

pikax · 2020-05-16T11:09:26Z

I tried not to make too many changes to the current tests, focused more on porting the tests from vue-next.

Hopefully this types will improve, and they were basically copy&paste from vue-next so updating them in the future should be straight forward, I'm also thinking in bringing the typescript type tests over, but waiting for the typescript 3.9 PR to be merged and the mixins

…w, also change message

antfu

LGTM. Let me know when you feel it's ready, I think I am able to help with merging.

I also notice this already covered #300. I will close it in favor of this.

antfu

There seems to have some uncaptured warnings for npm test which I think should make the tests failed but it didn't. https://github.com/vuejs/composition-api/pull/311/checks?check_run_id=723085160 I will try to investigate a bit.

EDIT: made a PR pikax#2

pikax · 2020-06-02T13:53:29Z

@antfu sorry missed your comment, didn't noticed the errors! Thank you

pikax · 2020-06-02T15:02:09Z

test/v3/runtime-core/apiLifecycle.spec.ts

+    expect(fn).toHaveBeenCalledTimes(1);
+  });
+
+  // it('onBeforeUnmount', async () => {


Comment this test because couldn't make this work, this was brought from vue-next not sure if we should fix this

pikax · 2020-06-02T15:02:17Z

test/v3/runtime-core/apiLifecycle.spec.ts

+  //   expect(fn).toHaveBeenCalledTimes(1);
+  // });
+
+  // it('onUnmounted', async () => {


antfu

LGTM and let's get it merged! Thanks for the great work!

LinusBorg and others added 5 commits March 30, 2020 19:48

fix(watch): component should runCleaup() on unmount

Verified

This commit was signed with the committer’s verified signature.

kampka Christian Kampka

GPG key ID: B88E140DB4FE1AA5

Verified
Learn about vigilant mode

8297872

close vuejs#293

feat: add unref API to match API with vue3

Verified

This commit was signed with the committer’s verified signature.

kampka Christian Kampka

GPG key ID: B88E140DB4FE1AA5

Verified
Learn about vigilant mode

2f3ec44

types: making ComputedRef types inline with vue3 and provide Computed…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

2957417

…Ref type

feat: bring API to vue-3 compatible

b697dd1

fix rollup build

1e1424c

pikax changed the title ~~feat: bring API to vue-3 compatible~~ [WIP] feat: bring API to vue-3 compatible Apr 19, 2020

pikax mentioned this pull request Apr 19, 2020

Type infer error if interface has "value" property #157

Closed

pikax added 5 commits April 19, 2020 19:11

ref tests, add some sort of effect api

e604038

implementation is wrong, but it just to have something kinda working, suggestions and help is welcome :)

Merge branch 'feat/unref_api' into feat/vue3_API

296ef63

# Conflicts: # src/apis/state.ts # src/reactivity/index.ts # src/reactivity/ref.ts

Merge branch 'types/computedRef' into feat/vue3_API

0c4cbe0

add unref test

0ac2500

more tests

e4c9d62

pikax mentioned this pull request Apr 19, 2020

(typescript) Date property in reactive object can't assign to pure Date type #279

Closed

fix computed.spec.ts

6f58691

pikax changed the title ~~[WIP] feat: bring API to vue-3 compatible~~ [WIP] feat: adding missing reactivity api from vue-next Apr 19, 2020

pikax added 10 commits April 20, 2020 20:53

watch/watchEffect making the apis inline with vue3

d6af20e

Merge branch 'master' into feat/vue3_API

db65ae0

# Conflicts: # src/apis/inject.ts # src/reactivity/ref.ts

fix state.spec.js tests

1c3ce8b

Merge remote-tracking branch 'upstream/fix-293-watch_cleanup-on-unmou…

a660cf7

…nt' into feat/vue3_API # Conflicts: # test/apis/watch.spec.js

tests

e4265b2

apiWatch.spec.ts passing

2a9e674

fix computed.spec.ts

d7ec18b

removing reactivity collection tests :(

74dc967

Vue2 Limitations

implementing shallowReactive

daa1955

removing bad import :/

e4a3f1d

This was referenced Apr 24, 2020

Typing the return of toRefs #315

Closed

Missing function toRef #313

Closed

pikax added 3 commits April 24, 2020 13:32

rename nonReactive to markRaw and add toRaw

fe08cf8

removing readonly.spec.ts

de0b7c6

add shallowRef

027200b

LinusBorg self-requested a review May 9, 2020 13:18

LinusBorg self-assigned this May 11, 2020

LinusBorg reviewed May 16, 2020

View reviewed changes

src/reactivity/reactive.ts Outdated Show resolved Hide resolved

LinusBorg reviewed May 16, 2020

View reviewed changes

src/apis/watch.ts Outdated Show resolved Hide resolved

LinusBorg approved these changes May 16, 2020

View reviewed changes

code-review fixes

618adff

LinusBorg mentioned this pull request May 24, 2020

invalid signature of inject #290

Closed

pikax added 2 commits May 30, 2020 12:57

feat(lifeCycleHook): getCurrentInstance inside lifecycle hook

9ee6013

feat: warn when calling lifecycleHook outside setup() instead of thro…

93e0c82

…w, also change message

antfu approved these changes May 31, 2020

View reviewed changes

This was referenced May 31, 2020

fix(watch): update watch options from lazy to immediate #300

Closed

fix(types): ensure correct oldValue typing based on lazy option #287

Closed

Missing UnwrapRef export #247

Closed

fix(type): fix incorrect ref unwrap #344

Merged

antfu requested changes May 31, 2020

View reviewed changes

fix(test): capture warning properly

afab8ec

fix: apiLifecycleTests

d2eca4e

pikax commented Jun 2, 2020

View reviewed changes

antfu approved these changes Jun 2, 2020

View reviewed changes

antfu merged commit 7701ff8 into vuejs:master Jun 2, 2020

pikax deleted the feat/vue3_API branch June 2, 2020 20:29

This was referenced Jun 3, 2020

chore: release v0.6.0 #349

Merged

Handle non-reactive nulls (#231) #241

Merged

carsoli mentioned this pull request Oct 27, 2020

fix release notes for v.0.6.0: missing breaking change #577

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: adding missing reactivity api from vue-next #311

feat: adding missing reactivity api from vue-next #311

pikax commented Apr 19, 2020 •

edited

Loading

LinusBorg commented May 9, 2020

LinusBorg commented May 16, 2020 •

edited

Loading

pikax commented May 16, 2020

antfu left a comment

antfu left a comment •

edited

Loading

pikax commented Jun 2, 2020

pikax Jun 2, 2020

pikax Jun 2, 2020

antfu left a comment

feat: adding missing reactivity api from vue-next #311

feat: adding missing reactivity api from vue-next #311

Conversation

pikax commented Apr 19, 2020 • edited Loading

Current problems

Breaking

Added

Changes

LinusBorg commented May 9, 2020

LinusBorg commented May 16, 2020 • edited Loading

pikax commented May 16, 2020

antfu left a comment

Choose a reason for hiding this comment

antfu left a comment • edited Loading

Choose a reason for hiding this comment

pikax commented Jun 2, 2020

pikax Jun 2, 2020

Choose a reason for hiding this comment

pikax Jun 2, 2020

Choose a reason for hiding this comment

antfu left a comment

Choose a reason for hiding this comment

pikax commented Apr 19, 2020 •

edited

Loading

LinusBorg commented May 16, 2020 •

edited

Loading

antfu left a comment •

edited

Loading