Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Export of ComponentInternalInstance #675

Closed
relief-melone opened this issue Apr 12, 2021 · 2 comments
Closed

Missing Export of ComponentInternalInstance #675

relief-melone opened this issue Apr 12, 2021 · 2 comments
Labels
contribution welcome The team would welcome a contribution from the community for this issue

Comments

@relief-melone
Copy link

At the moment ComponentInternalInstance is only exported by vue3 not by the vue2 composition api. It is still in the typings. Also getCurrentInstance returns this type but it's not exported by the composition api.

I wanted to ask if has been done for a reason and if not if it could be added?

@antfu antfu added the contribution welcome The team would welcome a contribution from the community for this issue label Apr 12, 2021
@relief-melone
Copy link
Author

relief-melone commented Apr 16, 2021

I'd happily contribute and add this as soon as I find the time. Is there a contribution guide or should I just create a pull request.

[edit]
This was easier than expected. I also noticet that the compilation failed because of the __spread array not beeing exported by tslib. This was fixed in rollup-plugin-typescript2 v0.30.0 also I needed to update tslib to 2.2.0 (i had this issue on several projects by now).

My question for the pr would additionally be what version you want the pr to have (of course this question is obsolete if there is a guide which answers all of that)
[/edit]

@relief-melone
Copy link
Author

I just added the PR. Not sure if the version bump to rc7 was correct though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome The team would welcome a contribution from the community for this issue
Projects
None yet
2 participants