fix(ssr): set() twice lose reactivity
#821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So it works 🤔 What is weird is that the error "toRefs() expects a reactive object" appears on the server on Nuxt even though it's running 1.2.2 Regarding the test, should we add this? It doesn't seem like it was added back then |
posva
changed the title
posva
commented
Oct 3, 2021
|
Found the problem: setting twice. I'm going to fix this on Pinia but I don't think this edge case is currently working as expected. |
posva
added a commit
to vuejs/pinia
that referenced
this pull request
Oct 3, 2021
Fix #648 If this PR vuejs/composition-api#821 gets fixed, this commit can be reverted
antfu
changed the title
set() twice lose reactivity
rajesh-bhavnani
pushed a commit
to rajesh-bhavnani/Jason-pinia
that referenced
this pull request
Dec 25, 2022
Fix #648 If this PR vuejs/composition-api#821 gets fixed, this commit can be reverted
arthur-king-excalibur
added a commit
to arthur-king-excalibur/vu-pinia
that referenced
this pull request
Dec 24, 2023
Fix #648 If this PR vuejs/composition-api#821 gets fixed, this commit can be reverted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #795
It seems to still be failing.
It creates vuejs/pinia#648