Skip to content

Commit

Permalink
fix(ssr): remove missing ssr directive transform error
Browse files Browse the repository at this point in the history
  • Loading branch information
yyx990803 committed Jan 16, 2022
1 parent 4dd0f34 commit 55cc4af
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 13 deletions.
4 changes: 1 addition & 3 deletions packages/compiler-ssr/src/errors.ts
Expand Up @@ -17,14 +17,12 @@ export function createSSRCompilerError(
}

export const enum SSRErrorCodes {
X_SSR_CUSTOM_DIRECTIVE_NO_TRANSFORM = DOMErrorCodes.__EXTEND_POINT__,
X_SSR_UNSAFE_ATTR_NAME,
X_SSR_UNSAFE_ATTR_NAME = DOMErrorCodes.__EXTEND_POINT__,
X_SSR_NO_TELEPORT_TARGET,
X_SSR_INVALID_AST_NODE
}

export const SSRErrorMessages: { [code: number]: string } = {
[SSRErrorCodes.X_SSR_CUSTOM_DIRECTIVE_NO_TRANSFORM]: `Custom directive is missing corresponding SSR transform and will be ignored.`,
[SSRErrorCodes.X_SSR_UNSAFE_ATTR_NAME]: `Unsafe attribute name for SSR.`,
[SSRErrorCodes.X_SSR_NO_TELEPORT_TARGET]: `Missing the 'to' prop on teleport element.`,
[SSRErrorCodes.X_SSR_INVALID_AST_NODE]: `Invalid AST node during SSR transform.`
Expand Down
12 changes: 2 additions & 10 deletions packages/compiler-ssr/src/transforms/ssrTransformElement.ts
Expand Up @@ -179,18 +179,10 @@ export const ssrTransformElement: NodeTransform = (node, context) => {
if (!hasDynamicVBind) {
node.children = [createInterpolation(prop.exp, prop.loc)]
}
} else {
} else if (!hasDynamicVBind) {
// Directive transforms.
const directiveTransform = context.directiveTransforms[prop.name]
if (!directiveTransform) {
// no corresponding ssr directive transform found.
context.onError(
createSSRCompilerError(
SSRErrorCodes.X_SSR_CUSTOM_DIRECTIVE_NO_TRANSFORM,
prop.loc
)
)
} else if (!hasDynamicVBind) {
if (directiveTransform) {
const { props, ssrTagParts } = directiveTransform(
prop,
node,
Expand Down

0 comments on commit 55cc4af

Please sign in to comment.