Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
fix(runtime-dom): fix option element value patching edge case (#4959)
fix #4956
  • Loading branch information
LinusBorg committed Nov 25, 2021
1 parent 3c449cd commit 89b2f92
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
3 changes: 3 additions & 0 deletions packages/runtime-dom/__tests__/patchProps.spec.ts
Expand Up @@ -29,9 +29,12 @@ describe('runtime-dom: props patching', () => {
// so we need to add tests for other elements
test('value for non-text input', () => {
const el = document.createElement('option')
el.textContent = 'foo' // #4956
patchProp(el, 'value', null, 'foo')
expect(el.getAttribute('value')).toBe('foo')
expect(el.value).toBe('foo')
patchProp(el, 'value', null, null)
el.textContent = ''
expect(el.value).toBe('')
// #3475
expect(el.getAttribute('value')).toBe(null)
Expand Down
8 changes: 7 additions & 1 deletion packages/runtime-dom/src/modules/props.ts
Expand Up @@ -31,7 +31,13 @@ export function patchDOMProp(
// non-string values will be stringified.
el._value = value
const newValue = value == null ? '' : value
if (el.value !== newValue) {
if (
el.value !== newValue ||
// #4956: always set for OPTION elements because its value falls back to
// textContent if no value attribute is present. And setting .value for
// OPTION has no side effect
el.tagName === 'OPTION'
) {
el.value = newValue
}
if (value == null) {
Expand Down

0 comments on commit 89b2f92

Please sign in to comment.