From b1817fe9eeb66a18f405ada9072149515654a9bd Mon Sep 17 00:00:00 2001 From: Evan You Date: Tue, 27 Sep 2022 16:39:15 +0800 Subject: [PATCH] fix(runtime-dom): fix unnecessary warning when setting coerced dom property value fix #6616 --- packages/runtime-dom/__tests__/patchProps.spec.ts | 2 ++ packages/runtime-dom/src/modules/props.ts | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/runtime-dom/__tests__/patchProps.spec.ts b/packages/runtime-dom/__tests__/patchProps.spec.ts index b7ce2302f80..10ef9e289b4 100644 --- a/packages/runtime-dom/__tests__/patchProps.spec.ts +++ b/packages/runtime-dom/__tests__/patchProps.spec.ts @@ -240,6 +240,8 @@ describe('runtime-dom: props patching', () => { expect(el.size).toBe(100) patchProp(el, 'size', 100, null) expect(el.getAttribute('size')).toBe(null) + expect('Failed setting prop "size" on ').not.toHaveBeenWarned() + patchProp(el, 'size', null, 'foobar') expect('Failed setting prop "size" on ').toHaveBeenWarnedLast() }) diff --git a/packages/runtime-dom/src/modules/props.ts b/packages/runtime-dom/src/modules/props.ts index 591f8caa7d0..1c1ad0c16f7 100644 --- a/packages/runtime-dom/src/modules/props.ts +++ b/packages/runtime-dom/src/modules/props.ts @@ -63,7 +63,6 @@ export function patchDOMProp( needRemove = true } else if (type === 'number') { // e.g. - // the value of some IDL attr must be greater than 0, e.g. input.size = 0 -> error value = 0 needRemove = true } @@ -96,7 +95,8 @@ export function patchDOMProp( try { el[key] = value } catch (e: any) { - if (__DEV__) { + // do not warn if value is auto-coerced from nullish values + if (__DEV__ && !needRemove) { warn( `Failed setting prop "${key}" on <${el.tagName.toLowerCase()}>: ` + `value ${value} is invalid.`,