Skip to content

Commit

Permalink
fix(compiler-sfc): handle empty strings during template usage analysi…
Browse files Browse the repository at this point in the history
…s of setup bindings (#4608)

fix #4599
  • Loading branch information
LinusBorg committed Sep 16, 2021
1 parent fcd5422 commit bdb1a79
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 1 deletion.
Expand Up @@ -202,6 +202,22 @@ return { props, a, emit }
}"
`;
exports[`SFC compile <script setup> dev mode import usage check attribute expressions 1`] = `
"import { defineComponent as _defineComponent } from 'vue'
import { bar, baz } from './x'
export default /*#__PURE__*/_defineComponent({
setup(__props, { expose }) {
expose()
const cond = true
return { cond, bar, baz }
}
})"
`;
exports[`SFC compile <script setup> dev mode import usage check components 1`] = `
"import { defineComponent as _defineComponent } from 'vue'
import { FooBar, FooBaz, FooQux, foo } from './x'
Expand Down
15 changes: 15 additions & 0 deletions packages/compiler-sfc/__tests__/compileScript.spec.ts
Expand Up @@ -342,6 +342,21 @@ defineExpose({ foo: 123 })
assertCode(content)
})

// https://github.com/vuejs/vue-next/issues/4599
test('attribute expressions', () => {
const { content } = compile(`
<script setup lang="ts">
import { bar, baz } from './x'
const cond = true
</script>
<template>
<div :class="[cond ? '' : bar(), 'default']" :style="baz"></div>
</template>
`)
expect(content).toMatch(`return { cond, bar, baz }`)
assertCode(content)
})

test('vue interpolations', () => {
const { content } = compile(`
<script setup lang="ts">
Expand Down
2 changes: 1 addition & 1 deletion packages/compiler-sfc/src/compileScript.ts
Expand Up @@ -1826,7 +1826,7 @@ function resolveTemplateUsageCheckString(sfc: SFCDescriptor) {

function stripStrings(exp: string) {
return exp
.replace(/'[^']+'|"[^"]+"/g, '')
.replace(/'[^']*'|"[^"]*"/g, '')
.replace(/`[^`]+`/g, stripTemplateString)
}

Expand Down

0 comments on commit bdb1a79

Please sign in to comment.