From f0a619693996a5a768cd606faec570ac14cd8f93 Mon Sep 17 00:00:00 2001 From: edison Date: Fri, 1 Dec 2023 15:54:40 +0800 Subject: [PATCH] fix(ssr): avoid computed being accidentally cached before server render (#9688) close #5300 --- packages/server-renderer/__tests__/ssrComputed.spec.ts | 1 - packages/server-renderer/src/render.ts | 5 ++++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/server-renderer/__tests__/ssrComputed.spec.ts b/packages/server-renderer/__tests__/ssrComputed.spec.ts index 5c5850e006d..52b45a63636 100644 --- a/packages/server-renderer/__tests__/ssrComputed.spec.ts +++ b/packages/server-renderer/__tests__/ssrComputed.spec.ts @@ -33,7 +33,6 @@ test('computed reactivity during SSR', async () => { // In both cases we need to fetch data. if (!msg.value) await store.fetchData() - expect(msg.value).toBe('hello world') return () => h('div', null, msg.value + msg.value + msg.value) }) diff --git a/packages/server-renderer/src/render.ts b/packages/server-renderer/src/render.ts index a1f327b4320..011d0840386 100644 --- a/packages/server-renderer/src/render.ts +++ b/packages/server-renderer/src/render.ts @@ -144,7 +144,10 @@ function renderComponentSubTree( // perf: enable caching of computed getters during render // since there cannot be state mutations during render. for (const e of instance.scope.effects) { - if (e.computed) e.computed._cacheable = true + if (e.computed) { + e.computed._dirty = true + e.computed._cacheable = true + } } const ssrRender = instance.ssrRender || comp.ssrRender