Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
fix(runtime-dom): ensure customElement handles empty props correctly. (
…#6182)

fix Scoped attribute in Vue file affects the use of web component #6163,#6895
  • Loading branch information
LinusBorg committed Nov 1, 2022
1 parent 3bed82b commit f67bb50
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
14 changes: 14 additions & 0 deletions packages/runtime-dom/__tests__/customElement.spec.ts
Expand Up @@ -210,6 +210,20 @@ describe('defineCustomElement', () => {
customElements.define('my-el-upgrade', E)
expect(el.shadowRoot.innerHTML).toBe(`foo: hello`)
})

// https://github.com/vuejs/core/issues/6163
test('handle components with no props', async () => {
const E = defineCustomElement({
render() {
return h('div', 'foo')
}
})
customElements.define('my-element-noprops', E)
const el = document.createElement('my-element-noprops')
container.appendChild(el)
await nextTick()
expect(el.shadowRoot!.innerHTML).toMatchInlineSnapshot('"<div>foo</div>"')
})
})

describe('emits', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime-dom/src/apiCustomElement.ts
Expand Up @@ -215,7 +215,7 @@ export class VueElement extends BaseClass {
}).observe(this, { attributes: true })

const resolve = (def: InnerComponentDef) => {
const { props, styles } = def
const { props = {}, styles } = def
const hasOptions = !isArray(props)
const rawKeys = props ? (hasOptions ? Object.keys(props) : props) : []

Expand Down

0 comments on commit f67bb50

Please sign in to comment.