Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on 'update' non-resolved async component #10017

Closed
mmis1000 opened this issue Jan 6, 2024 · 1 comment
Closed

Crash on 'update' non-resolved async component #10017

mmis1000 opened this issue Jan 6, 2024 · 1 comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working scope: suspense

Comments

@mmis1000
Copy link
Contributor

mmis1000 commented Jan 6, 2024

Vue version

3.4.5

Link to minimal reproduction

https://play.vuejs.org/#eNqVVVtv2jAU/itHeUmQIGnX7YVBVTb1YdNuWrunZQ8ZOYCbxI5sB1oh/vuO7TgkpVs7iaqc+3cun9kHi7qOtw0G02CmlpLVGhTqpr5MOatqITW8F1UNKykqCOPECMY97Mx7uGlUjVzhGCSu4ND6OqeULwVXGgp8gLmxR2ERjrw2z3Tm1eb70SL4j5o0SNZoBPNL2KccIElAb5gia/kAm6ymsjlkK40SGGeaZSWoFgwlVaLcYhumBOwQdhnT0HDNSsqDBA6ArSAicPE2KxuqNp9DWJyHI1cPLEJvA4vxFXUFcEg5fTzWTyLLMX8aK32oFlSC6pIPbpFTyAoy9cCXsKR5Ck4qHyLZeo2S8bXxsQkqzLjJkdFmfHOkbvvLTWCvAQvfgpslbp+0SRI0VnVJAyUJYOZXZiWS7Y6nxTwNKFUawNR0SpL5R+JVaRskhe/VKO3g3ZqsxX0lS+KKJL0qs6QDEIwDrWhyK7aO75TgdHl2YGlghsFKlF9rzWiyaTD1a0iDrCzF7qPVadng2OuXG1wWT+jv1L3RpcE3GhRKOoSgs+lMrlE78/XNF7yn752xEnlTkvc/jN/N6BuD0bm9a3hOsHt+Fu0HSxBa5a26vtc0CN+UAWqPyPqnAVHFLOBvrR/hXsQX/vhoip6Lp9SVPXb6veQDZr7t+SzMJQ5Y3mnOHdfJ1/y5c6+lqBUdWo4rxvGbkaK9MRu0xRRu6Ib5euw15oQGysNomA8rIqVPd02Cin6G7uDCMYS9Kwt/daFdV5GnXFvOZIsGQTbmWPRIC684UqPNMTtOZEp8oOO2PccF3XaPC66yK9jiHXnuTFoCucCWRpZgfQ0RxSLqc2M4++d2+7l9Vk52+7/7Gg4psy8lxx2Qf8UURtL0ShBuWYWi0ZEcw/nZ2dnIhjy/yP7mWsxPb64bZIfnJQvL2fZysVjAfl8cDrPEiKeTdWObVFn96N1xhiHpaJCO3ButazVNkmXOKSzHkm1lzFEnvK6SK3JLpPlFqXCSi+rqIn4dv6H6SvfVMapq8luKHb1ElKT3UJh4+zzJiaQfM5TmGXlZ2Udh/dKPTCflu0fk8AeG+bnk

Steps to reproduce

  1. Open the playground

What is expected?

The text is AAA data2, and there is no error message.

What is actually happening?

The text is AAA data, and an error is shown.

System Info

No response

Any additional comments?

It used to work in preview of pr #7290 .

The playground of the commit shows the result correctly.

Probably it is also regressed by this commit

@edison1105 edison1105 added 🐞 bug Something isn't working scope: suspense labels Jan 7, 2024
@yyx990803 yyx990803 added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label Jan 9, 2024
@yyx990803
Copy link
Member

A note on why we can't just do initialVNode.el = placeholder.el:

In component's render effect on initial mount, we use the presence of el to serve as a check for adopted server-rendered DOM. If el is present, it will perform hydration instead of client mount. This is why the previous fix broke Nuxt in ecosystem-ci.

edison1105 pushed a commit to edison1105/vuejs-core that referenced this issue Jan 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working scope: suspense
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants