Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hasOwnProperty is not tracked #2619

Closed
skirtles-code opened this issue Nov 16, 2020 · 0 comments
Closed

hasOwnProperty is not tracked #2619

skirtles-code opened this issue Nov 16, 2020 · 0 comments
Labels
has PR A pull request has already been submitted to solve the issue scope: reactivity

Comments

@skirtles-code
Copy link
Contributor

Version

3.0.2

Reproduction link

https://jsfiddle.net/skirtle/1h6ucq9p/

Steps to reproduce

  1. Using the example provided, click the button 'Change'.
  2. No rendering occurs.
  3. Click 'Force' to see the changes.

What is expected?

Using hasOwnProperty during rendering should track the corresponding property.

It seems that we would need a proxy handler for getOwnPropertyDescriptor. I don't see anything like that in the current code.

If this omission is by design then I think it should be documented.
@edison1105 edison1105 mentioned this issue Nov 17, 2020
Closed
@posva posva added has PR A pull request has already been submitted to solve the issue scope: reactivity labels Nov 18, 2020
chrislone pushed a commit to chrislone/core that referenced this issue Feb 4, 2023
@yyx990803
fix(reactivity): track hasOwnProperty
6e6ece6 
fix vuejs#2619
close vuejs#2621
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this issue Apr 12, 2023
@yyx990803 @zhangzhonghe
fix(reactivity): track hasOwnProperty
85983fb 
fix vuejs#2619
close vuejs#2621
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
has PR A pull request has already been submitted to solve the issue scope: reactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(reactivity): fix track hasOwnProperty edison1105/vuejs-core
2 participants
@posva @skirtles-code