Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(refSugar): should transform $ref when used in typed declaration #4446

Merged
merged 2 commits into from Sep 1, 2021
Merged

fix(refSugar): should transform $ref when used in typed declaration #4446

merged 2 commits into from Sep 1, 2021

Conversation

edison1105
Copy link
Member

fix #4442

@edison1105 edison1105 changed the title fix(refSugar): should transform ref with typed declaration fix(refSugar): should transform $ref when used with typed declaration Aug 26, 2021
@edison1105 edison1105 marked this pull request as draft August 26, 2021 01:33
@edison1105 edison1105 changed the title fix(refSugar): should transform $ref when used with typed declaration fix(refSugar): should transform $ref when used in typed declaration Aug 26, 2021
@edison1105 edison1105 marked this pull request as ready for review August 26, 2021 01:53
@edison1105
fix(refSugar): should transform ref with typed declaration
b4189ed 
chore: improve RE

test: improve test case
@sxzz
Copy link
Member

sxzz commented Aug 26, 2021

It still can't transform with spaces.

let msg = $ref < string > ('Hello World!')

@yyx990803 yyx990803 merged commit 33cf6c8 into vuejs:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent $ref codegen
3 participants
@edison1105 @sxzz @yyx990803