Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errorHandler not used when hydrated, due to null instance #4479

Closed
danelowe opened this issue Sep 1, 2021 · 0 comments · Fixed by #4529
Closed

errorHandler not used when hydrated, due to null instance #4479

danelowe opened this issue Sep 1, 2021 · 0 comments · Fixed by #4529
Labels
🐞 bug Something isn't working scope: ssr

Comments

@danelowe
Copy link

danelowe commented Sep 1, 2021

Version

3.2.6

Reproduction link

github.com

Steps to reproduce

Reproduction is a copy of https://github.com/vitejs/vite/tree/main/packages/playground/ssr-vue with additon of errorHandler to main.js, and button to Home.vue.

npm run dev Then click the Throw error button on home page.

What is expected?

The custom errorHandler gets called. Which logs 'no error here'

What is actually happening?

The error is logged to console.


Trying to set up Sentry.

Related to #1336

In callWithErrorHandling, instance is null.

Add breakpoint to createInvoker. Look back in the stack to hydrateElement. In hydrateElement, parentComponent is set, but not passed to patchProp

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Something isn't working scope: ssr
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants