Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open handle leaks in createSSRApp #4815

Closed
07akioni opened this issue Oct 18, 2021 · 1 comment
Closed

open handle leaks in createSSRApp #4815

07akioni opened this issue Oct 18, 2021 · 1 comment
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working

Comments

@07akioni
Copy link
Contributor

Version

3.2.20

Reproduction link

github.com

Steps to reproduce

npm run test

What is expected?

jest exits without warning

What is actually happening?

image
@LinusBorg
Copy link
Member

LinusBorg commented Oct 19, 2021 •
edited

Caused by f4639e0

Not limited to SSR apps.

We should find a way to skip this setTimeout, (or potentially the whole devtools setup call?*) when we are:

a) in running tests
b) in jest
c) in jsdom (detection)

*: we likely want to keep the devtools setup as we might want to use devtools for in-browser-tests - we should rather skip the setTimeout only.

@LinusBorg LinusBorg added 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working labels Oct 19, 2021
@yyx990803 yyx990803 added ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. and removed 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Nov 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yyx990803 @LinusBorg @07akioni