Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: named ref in v-for regression fix(#5116) #5118

Merged
merged 3 commits into from Apr 12, 2022
Merged

Fix: named ref in v-for regression fix(#5116) #5118

merged 3 commits into from Apr 12, 2022

Conversation

lidlanca
Copy link
Contributor

@lidlanca lidlanca commented Dec 15, 2021 •
edited by LinusBorg

closes #5116

closes #5447

closes #5525

@netlify
Copy link

netlify bot commented Feb 18, 2022 •
edited

✔️ Deploy Preview for vue-next-template-explorer ready!

🔨 Explore the source changes: 6305830

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/620fdedbf1b6ed00086b6336

😎 Browse the preview: https://deploy-preview-5118--vue-next-template-explorer.netlify.app

@netlify
Copy link

netlify bot commented Feb 18, 2022 •
edited

✔️ Deploy Preview for vuejs-coverage ready!

🔨 Explore the source changes: 6305830

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/620fdedb1a797e0007fd3abc

😎 Browse the preview: https://deploy-preview-5118--vuejs-coverage.netlify.app

@netlify
Copy link

netlify bot commented Feb 18, 2022 •
edited

✔️ Deploy Preview for vue-sfc-playground ready!

🔨 Explore the source changes: 6305830

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/620fdedb0e828000084c248d

😎 Browse the preview: https://deploy-preview-5118--vue-sfc-playground.netlify.app/

@lidlanca
Copy link
Contributor Author

lidlanca commented Feb 18, 2022 •
edited

also fixes: #5447

sfc playground preview #5447 repro

sfc playground preview #5166 repro

@lidlanca lidlanca mentioned this pull request Feb 18, 2022
Closed
@ygj6
Copy link
Member

ygj6 commented Feb 19, 2022 •
edited

Look at this example:vue-sfc-playground

The output value should be 1.:grin:

@lidlanca
Copy link
Contributor Author

lidlanca commented Feb 19, 2022 •
edited

Look at this example:vue-sfc-playground

The output value should be 1.😁

Can you explain

There are 3 elements. The output is the length of the ref array with truthy value

@ygj6
Copy link
Member

ygj6 commented Feb 19, 2022

Look at this example:vue-sfc-playground
The output value should be 1.😁

Can you explain

There are 3 elements. The output is the length of the ref array with truthy value

sorry，I seem to have misunderstood it.

@LinusBorg LinusBorg self-requested a review February 19, 2022 10:01
@LinusBorg LinusBorg added ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. ready to merge The PR is ready to be merged. labels Feb 19, 2022
@LinusBorg LinusBorg added this to Approved in Next Patch Mar 10, 2022
@LinusBorg LinusBorg moved this from Approved to In Review in Next Patch Mar 10, 2022
@LinusBorg LinusBorg moved this from In Review to Approved in Next Patch Mar 10, 2022
@lidlanca lidlanca mentioned this pull request Mar 15, 2022
Closed
@cexbrayat cexbrayat mentioned this pull request Mar 16, 2022
Closed
@LinusBorg LinusBorg moved this from Approved to High Priority in Next Patch Apr 10, 2022
@yyx990803 yyx990803 merged commit cee1eaf into vuejs:main Apr 12, 2022
Next Patch automation moved this from High Priority to Done Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusBorg LinusBorg LinusBorg approved these changes

Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. ready to merge The PR is ready to be merged.
Projects
Next Patch
Done
Milestone
No milestone
4 participants
@lidlanca @ygj6 @LinusBorg @yyx990803