Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compat): convertLegacyVModelProps should merge model option in mixins #5251

Merged
merged 3 commits into from Jan 21, 2022

Conversation

moesoha
Copy link
Contributor

@moesoha moesoha commented Jan 13, 2022

If a Vue 2 component defines model option via mixins, convertLegacyVModelProps will not take care of it and break it.

@netlify
Copy link

netlify bot commented Jan 21, 2022

✔️ Deploy Preview for vue-sfc-playground ready!

🔨 Explore the source changes: 2f3510a

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/61ea58cbf64fc30007e795d8

😎 Browse the preview: https://deploy-preview-5251--vue-sfc-playground.netlify.app/

@netlify
Copy link

netlify bot commented Jan 21, 2022

✔️ Deploy Preview for vuejs-coverage ready!

🔨 Explore the source changes: 2f3510a

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/61ea58cbfbf60300083a76e0

😎 Browse the preview: https://deploy-preview-5251--vuejs-coverage.netlify.app

@netlify
Copy link

netlify bot commented Jan 21, 2022

✔️ Deploy Preview for vue-next-template-explorer ready!

🔨 Explore the source changes: 2f3510a

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/61ea58cb89a7d400076db6a1

😎 Browse the preview: https://deploy-preview-5251--vue-next-template-explorer.netlify.app

@yyx990803
Copy link
Member

Added logic for recursive mixins with mixins.

@yyx990803 yyx990803 merged commit 72130ac into vuejs:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants