Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something (looks like maybe static hoisting) is breaking HMR #5320

Closed
AaronBeaudoin opened this issue Jan 24, 2022 · 2 comments
Closed

Something (looks like maybe static hoisting) is breaking HMR #5320

AaronBeaudoin opened this issue Jan 24, 2022 · 2 comments

Comments

@AaronBeaudoin
Copy link

AaronBeaudoin commented Jan 24, 2022

Version

3.2.29

Reproduction Link

https://github.com/AaronBeaudoin/vite-vue-ssr-bug-repr/tree/vanilla

This repo is a stripped down version of Vite's ssr-vue playground.

Steps to Reproduce

Steps are in the repo's README.md file.

What is expected?

When changing the "DOESN'T WORK" text, HMR instantly responds and updates the page.

What is actually happening?

When changing the "DOESN'T WORK" text, HMR doesn't work and an error is logged in the console from the Vue runtime.

Extra Info

This issue was originally posted here to the Vite repo, but it looks like it's very likely actually an issue with Vue itself.

@AaronBeaudoin
Copy link
Author

Hi all. This is a real weird one and I've tried to figure out the cause for this strange behavior but I've had pretty much no success. Would someone with more experience be willing to step in and take a look? Thanks!

@AaronBeaudoin
Copy link
Author

Fixed by #5406.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant