fix(runtime-dom): properly handle custom style properties with falsy values (fix: #5322) #5348
+13
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
style definition objects that had an initially falsy value for a custom property would add that custom property with the stringified falsy value:
Note that this only affected initial values. if the falsy value was added in an update, the property was properly removed.
After this PR, the custom property would not be added in the first place on mount:
close: #5322