Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-core): remove child node key validation for template vFor (Fix #5360) #5392

Closed
wants to merge 2 commits into from
Closed

fix(compiler-core): remove child node key validation for template vFor (Fix #5360) #5392

wants to merge 2 commits into from

Conversation

espresso
Copy link

@espresso espresso commented Feb 9, 2022 •
edited by LinusBorg

As discussed within #5360, remove the validation that prevents child nodes of templates that contain a v-for directive from having keys.

Fix #5360
Fix #4718

@espresso
fix(compiler-core): remove child node key validation for template vFor (
e2daa54 
Fix #5360)

Remove the validation that prevents child nodes of templates that contain a v-for directive from having keys.

Fix #5360
@netlify
Copy link

netlify bot commented Feb 9, 2022 •
edited

✔️ Deploy Preview for vuejs-coverage ready!

🔨 Explore the source changes: d6f5e94

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/62040df28da2b500070684b3

😎 Browse the preview: https://deploy-preview-5392--vuejs-coverage.netlify.app

@netlify
Copy link

netlify bot commented Feb 9, 2022 •
edited

✔️ Deploy Preview for vue-next-template-explorer ready!

🔨 Explore the source changes: d6f5e94

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/62040df209eb330007295d8b

😎 Browse the preview: https://deploy-preview-5392--vue-next-template-explorer.netlify.app

@netlify
Copy link

netlify bot commented Feb 9, 2022 •
edited

✔️ Deploy Preview for vue-sfc-playground ready!

🔨 Explore the source changes: d6f5e94

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/62040df29b80db00074e1985

😎 Browse the preview: https://deploy-preview-5392--vue-sfc-playground.netlify.app/

@espresso
Copy link
Author

espresso commented Feb 9, 2022

Merged wrong branch. Will re-submit.

@espresso espresso closed this Feb 9, 2022
@espresso espresso deleted the ctks/remove-template-vfor-key-validation-fix-5360 branch February 9, 2022 18:32
@espresso espresso restored the ctks/remove-template-vfor-key-validation-fix-5360 branch February 9, 2022 18:51
@espresso espresso reopened this Feb 9, 2022
@espresso
Update vFor.spec.ts
d6f5e94 
Added back missing bracket.
@espresso
Copy link
Author

espresso commented Feb 9, 2022

Decided to just update this PR w/ the correct code instead of creating a new one. Sorry for the back and forth.

@LinusBorg LinusBorg added this to Planned, might need fresh review in Next Patch Mar 10, 2022
@LinusBorg LinusBorg added ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. scope: transition labels Mar 11, 2022
@LinusBorg
Copy link
Member

@yyx990803 comment in #5360 that lead to this PR

Basically, we can drop this check as it simply works without it, and losing it is even necessary to be able to properly key transition-group children.

@LinusBorg LinusBorg moved this from Planned, might need fresh review to In Review in Next Patch Mar 11, 2022
@LinusBorg LinusBorg moved this from Open for Review to High Priority in Next Patch Apr 10, 2022
@yyx990803 yyx990803 closed this in 4311ddd Apr 12, 2022
@yyx990803 yyx990803 removed this from High Priority in Next Patch Apr 12, 2022
@espresso espresso deleted the ctks/remove-template-vfor-key-validation-fix-5360 branch April 19, 2022 03:44
@bodograumann bodograumann mentioned this pull request Apr 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. scope: transition
Projects
None yet
Milestone
No milestone
2 participants
@espresso @LinusBorg