fix(runtime-core): ensure that errors in slot function execution do not affect block tracking (fix #5657) #5670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-sfc-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vue-next-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vuejs-coverage ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
javastation
changed the title
javastation
changed the title
|
How far away do you think this PR will be ready for review @javastation? I am quite keen to have this as I believe this will fix an issue I have |
|
hi @edison1105, it seems that quite a few people have encountered this problem and I hope you can help review this pr. Thanks for your suggestions on my previous pr. |
Tried my best, wait a little longer. |
edison1105
reviewed
Jul 4, 2022
|
Watching and waiting... |
|
Any updates on this? |
1 similar comment
|
Any updates on this? |
antfu
changed the title
antfu
approved these changes
Oct 10, 2022
antfu
added
❗ p4-important
chrislone
pushed a commit
to chrislone/core
that referenced
this pull request
Feb 4, 2023
…ot affect block tracking (vuejs#5670) fix vuejs#5657
zhangzhonghe
pushed a commit
to zhangzhonghe/core
that referenced
this pull request
Apr 12, 2023
…ot affect block tracking (vuejs#5670) fix vuejs#5657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5657
ensure that errors in slot function execution do not affect block tracking, and then affect dynamic children and patch