Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-dom): apiCustomElement fix #5687 and #5793 #5794

Closed
wants to merge 3 commits into from

Conversation

hcg1023
Copy link

@hcg1023 hcg1023 commented Apr 24, 2022

fix #5687
and
fix #5793

@netlify
Copy link

netlify bot commented Apr 24, 2022

Deploy Preview for vue-sfc-playground ready!

Name Link
🔨 Latest commit 55a61c9
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/62650f58ec76800008d01ab6
😎 Deploy Preview https://deploy-preview-5794--vue-sfc-playground.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 24, 2022

Deploy Preview for vuejs-coverage ready!

Name Link
🔨 Latest commit 55a61c9
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/62650f586af7d60009caf0af
😎 Deploy Preview https://deploy-preview-5794--vuejs-coverage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 24, 2022

Deploy Preview for vue-next-template-explorer ready!

Name Link
🔨 Latest commit 55a61c9
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/62650f588a7e00000919536e
😎 Deploy Preview https://deploy-preview-5794--vue-next-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hcg1023 hcg1023 changed the title Fix #5687 and #5793 fix(runtime-dom): apiCustomElement fix #5687 and #5793 Apr 24, 2022
yyx990803 added a commit that referenced this pull request Nov 11, 2022
@yyx990803
Copy link
Member

Thanks a lot for the PR. However, since #5687 is expected behavior, part of this PR isn't really necessary.

I adapted the part that applies to #5793 in 89f37ce, hope you don't mind. In the future, please make sure to submit separate PRs when fixing different issues. Again thanks for the PR.

@yyx990803 yyx990803 closed this Nov 11, 2022
Custom Elements Bugsquash automation moved this from PRs to Done Nov 11, 2022
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment