Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: <Suspense> + <Transition> means mounted() runs too early #5952

Closed
wants to merge 1 commit into from

Conversation

liulinboyi
Copy link
Member

close #5844
fix: <Suspense> + <Transition> means mounted() runs too early

@liulinboyi
Copy link
Member Author

Preview

@Hugofgx9
Copy link

Hugofgx9 commented Jul 7, 2022

when will this be release ? This issue causes bugs on nuxt 3 which make it difficult to use in production for the moment

@Atinux
Copy link

Atinux commented Jul 7, 2022

What is stopping this PR from changing its draft status?

@richgcook
Copy link

Any thoughts on when this fix would be merged?

@richgcook
Copy link

Any thoughts on when this fix would be merged?

Anyone?

@warflash
Copy link

warflash commented Oct 6, 2022

🙏

@BenjaminOddou
Copy link

👀

@stikoo
Copy link

stikoo commented Nov 11, 2022

Oh, this would solve soooooo many issues we're having with Nuxt 3 right now, please please give this the love it deserves! 🙏

@fabienbergerat
Copy link

@stikoo agreed... For me this issue makes nuxt 3 pretty much pointless. It made me lose so much time trying to figure out the least ugly workarounds 🤯

@Aljodomo
Copy link

Great!

@fabienbergerat
Copy link

Is there any update on the status of this issue?

@Willadaygo
Copy link

Nudge nudge 🥲?

@brunodeangelis
Copy link

No disrespect to Vue maintainers, but I just find amazing that it's been a year since this PR was posted and there are no signs of merging yet. This bug heavily impacts the biggest and most used Vue framework, Nuxt 3, and makes it a huge pain to deal with what would be an otherwise excellent DX (and UX for that matter).

@zsavajji
Copy link

This single issue is preventing me from trying to migrate our next projects to the Nuxt 3 ecosystem, it's a pretty huge deal breaker 😢

@maximilliangeorge
Copy link

For anyone else waiting, this composable can work as an interim solution:
nuxt/nuxt#13471 (comment)

@liulinboyi
Copy link
Member Author

liulinboyi commented May 11, 2023

For anyone else waiting, this composable can work as an interim solution: nuxt/nuxt#13471 (comment)

The workaround is Cool! PlayGround

nuxt/nuxt#13471 (comment)

@davidwebca
Copy link

We rely on this in our workflow, this seems to happen only when JS transitions are used and with mode "out-in" if I'm not wrong. Commenting to follow updates.

@beejaz
Copy link

beejaz commented Jul 9, 2023

Would be nice if this bug could be squeezed. Stuck in Nuxt3 workarounds for now.

@michaelpumo
Copy link

I can't believe it's been 1 year + 2 months since this PR was created and it's still not merged? This is a pretty major bug and the kind of bug that can break applications without realising it. Is this normal? It would be great if we can get this merged in and sorted once and for all. Thanks.

@joseehilton147
Copy link

1 year and 3 months and counting, what's is stopping this from being merged?

@JasonGotGithub
Copy link

JasonGotGithub commented Aug 28, 2023

Out of curiosity, is this shelved or pending merging? From a creative development standpoint, it makes migrating to Vue 3 hard so it would great to get an update on it. Also, to assess if a search to an alternative solution (or framework) needs to happen in the case where the current behavior is the intended behavior

@JasonGotGithub
Copy link

Hi @sodatea, would you be able to shed some light on this?

@sodatea
Copy link
Member

sodatea commented Sep 27, 2023

  • This is a p4 issue, meaning we'll prioritize it when reviewing and merging the next batch of PRs.
  • But this PR, in its current status, isn't ready for merge (or even for review) because it lacks tests. Besides, the branch is far behind the current main branch. The code must be rebased first.
  • If you are really bothered by the bug, there's a workaround in the comments: onMounted hook running before DOM is available nuxt/nuxt#13471 (comment) Please give it a try.

@maximilliangeorge
Copy link

maximilliangeorge commented Sep 27, 2023

@sodatea Thanks for updating us 💖 I can vouch for the aforementioned workarounds, I'm currently using them successfully. But it will be great to see a proper solution.

@stoner-w
Copy link

@sodatea Dear Vue team members.

I would like to inquire if there is a plan for merging PRs? While I have been in the process of upgrading to Vue 3, I have encountered several issues, and some of these issues could be resolved through specific PRs. However, these PRs have remained in a state of suspension for some time now. Consequently, I have had to resort to alternative methods to address my problems, but I believe this is not an ideal approach. Moreover, these temporary solutions may potentially lead to issues in my application once these PRs are eventually fixed.

@daniluk4000
Copy link

@sodatea Dear Vue team members.

I would like to inquire if there is a plan for merging PRs? While I have been in the process of upgrading to Vue 3, I have encountered several issues, and some of these issues could be resolved through specific PRs. However, these PRs have remained in a state of suspension for some time now. Consequently, I have had to resort to alternative methods to address my problems, but I believe this is not an ideal approach. Moreover, these temporary solutions may potentially lead to issues in my application once these PRs are eventually fixed.

I have pack of answers there:
#7050
#8560

@stoner-w
Copy link

@daniluk4000 I hope it can be processed as soon as possible, many issues have been bothering me for a long time.

@daniluk4000
Copy link

@daniluk4000 I hope it can be processed as soon as possible, many issues have been bothering me for a long time.

Lol I didn't see you literally commented the last one, sorry.

I hope it can be processed as soon as possible

So do I.

@pikax
Copy link
Member

pikax commented Oct 20, 2023

Closing this in favour of #9388

@pikax pikax closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<Suspense> + <Transition> means mounted() runs too early