Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): in operator returning false for built-in instance properties in exposeProxy (fix #6137) #6138

Merged
merged 4 commits into from Oct 26, 2022

Conversation

DrJume
Copy link
Contributor

@DrJume DrJume commented Jun 18, 2022

This PR tries to fix #6137.

Background info

The component exposeProxy implements a fallback logic for accessing built-in instance properties but was missing the same logic for the in operator in the Proxy's has() handler.

…nce properties in `exposeProxy`

`exposeProxy` implements a fallback logic for accessing built-in instance properties but was missing the same logic for the `in` operator in the Proxy's `has()` handler.

fix vuejs#6137
@LinusBorg LinusBorg self-requested a review July 4, 2022 08:56
@DrJume
Copy link
Contributor Author

DrJume commented Aug 20, 2022

Hey, just wanted to ask if there is anything I can do to get this fix merged 🙂

@DrJume
Copy link
Contributor Author

DrJume commented Oct 5, 2022

@yyx990803 sorry for tagging. This is my last attempt to try to get this fix merged.
If there is anything left to do, please tell me. 😔

@LinusBorg
Copy link
Member

We are just starting an effort to clean up and re-review PRs that are unmerged even though ready to go. We have accumulated quite a number of those so it may still take a bit.

Please be a bit more patient. Thanks

@LinusBorg LinusBorg added the ready to merge The PR is ready to be merged. label Oct 10, 2022
@yyx990803 yyx990803 merged commit 32b5124 into vuejs:main Oct 26, 2022
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 p2-edge-case ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in operator not working correctly with component instance exposeProxy
5 participants