Skip to content

fix(compiler-sfc): require <template> or <script> in SFC #6781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 8, 2022
Merged

fix(compiler-sfc): require <template> or <script> in SFC #6781

merged 3 commits into from
Nov 8, 2022
+18 −3

Conversation

shengxinjing
Copy link
Contributor

fix #6676

@antfu antfu changed the title fix(compiler-sfc): Single file Component at least has a <template> or… fix(compiler-sfc): require <template> or <script> in SFC Oct 3, 2022
antfu
antfu approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM. Though I think the message could be improved.

@shengxinjing
Copy link
Contributor Author

English is a little hard for me. haha 😃

@yyx990803 @antfu
Update packages/compiler-sfc/src/parse.ts
505b35c 
Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
@netlify
Copy link

netlify bot commented Nov 8, 2022

❌ Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 505b35c
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/6369cc42d771bd00091eda53

@yyx990803
chore: fix test

Unverified

The email in this signature doesn’t match the committer email.
GPG key ID: 933B01F40B5CA946
Expired
Learn about vigilant mode
ced5821
@yyx990803 yyx990803 merged commit a0c7f27 into vuejs:main Nov 8, 2022
@shengxinjing shengxinjing deleted the warn6676 branch November 8, 2022 03:35
@btea btea mentioned this pull request Nov 10, 2022
Closed
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
@shengxinjing
fix(compiler-sfc): require <template> or <script> in SFC (vuejs#6781)

Unverified

The email in this signature doesn’t match the committer email.
GPG key ID: 933B01F40B5CA946
Expired
Learn about vigilant mode
dce9bef 
fix vuejs#6676
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this pull request Apr 12, 2023
@shengxinjing @zhangzhonghe
fix(compiler-sfc): require <template> or <script> in SFC (vuejs#6781)

Unverified

The email in this signature doesn’t match the committer email.
GPG key ID: 933B01F40B5CA946
Expired
Learn about vigilant mode
b95a2c3 
fix vuejs#6676
@sapphi-red sapphi-red mentioned this pull request May 8, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output an error when <template> nor <script> is included in SFC when parsing
3 participants
@shengxinjing @antfu @yyx990803