Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeepAlive & root text node: Failed to execute 'insertBefore' on 'Node' #6852

Closed
skirtles-code opened this issue Oct 11, 2022 · 0 comments · Fixed by #6858
Closed

KeepAlive & root text node: Failed to execute 'insertBefore' on 'Node' #6852

skirtles-code opened this issue Oct 11, 2022 · 0 comments · Fixed by #6858
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working scope: hmr

Comments

@skirtles-code
Copy link
Contributor

Vue version

3.2.40

Link to minimal reproduction

https://sfc.vuejs.org/#eNp9UU1vwjAM/SteLh0Sbe6oTJt23o1jLqW4JdB8KEnLJtT/PqfpGGNST4nt52c/vyt7s7YYemQbVvraSRvAY+jti9BSWeMCXMFhAyM0zijICJrdSh9f70fZHeZSwec48hEIQOjaaE+MR3OBbeR5Dq7HVayUPI2jQRQEVLarAlIEUO77EIyG17qT9Xkr2Nz/FF/BJgzAzrRthxOep4bUfEa0edXJIZFR5mfNIZfNzCYY8ATnf/Alv23C1izJzFVli5M3mm50nWTNBS/YBqZMzJHoGAt2DMH6Dee+qeMlTr4wruX0K1yvg1RYoFf53pmLR0fEgq3vODglB3S5Q31Ah26J8wH6jzfSjkKPJOXOmkeroat0S3eJepZt/3U04GeYHc2y1ZKbO0LSU0pt+0AWKHPALk6L+eTC3dGFZuM31MziVQ==

Steps to reproduce

  1. Type something in the <input>.
  2. Click the Toggle button.
  3. Observe error.

What is expected?

No error.

What is actually happening?

Error in console, rendering update fails.

Failed to execute 'insertBefore' on 'Node': parameter 1 is not of type 'Node'.

System Info

No response

Any additional comments?

  • Happens in both dev and production mode.
  • Seems to have been a problem for a while, it isn't new in 3.2.40.
  • The root text node in the child seems to be required to cause the problem.
  • If you don't type anything in the <input>, everything seems to be toggle fine. I assume some internal state is getting changed by the first re-render that breaks the second re-render.
zhangzhonghe added a commit to zhangzhonghe/core that referenced this issue Oct 12, 2022
@zhangzhonghe
fix(runtime-core): should also inherit the DOM el of the text nodes (v…
bce1a4a 
…uejs#6852)
This was referenced Oct 12, 2022
Merged
Closed
Closed
@zhangzhonghe zhangzhonghe mentioned this issue Nov 4, 2022
Closed
@edison1105 edison1105 added 🐞 bug Something isn't working ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. scope: hmr labels Nov 4, 2022
yyx990803 pushed a commit that referenced this issue Nov 10, 2022
@zhangzhonghe
fix(runtime-core): fix move/removal of static fragments containing te…
4049ffc 
…xt nodes (#6858)

fix #6852
chrislone pushed a commit to chrislone/core that referenced this issue Feb 4, 2023
@zhangzhonghe
fix(runtime-core): fix move/removal of static fragments containing te…
be33b21 
…xt nodes (vuejs#6858)

fix vuejs#6852
zhangzhonghe added a commit to zhangzhonghe/core that referenced this issue Apr 12, 2023
@zhangzhonghe
fix(runtime-core): fix move/removal of static fragments containing te…
e0cb6cb 
…xt nodes (vuejs#6858)

fix vuejs#6852
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working scope: hmr
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(runtime-core): should also inherit the DOM el of the text nodes (… zhangzhonghe/core
2 participants
@edison1105 @skirtles-code