fix: stricter type condition for EventHandlers
#6855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxzz
approved these changes
Oct 12, 2022
antfu
approved these changes
Oct 12, 2022
|
Will this fix also be applied for Vue |
strayer
added a commit
to iscc/iscc-web
that referenced
this pull request
Oct 12, 2022
shy1118999
added a commit
to shy1118999/shy-vue-template
that referenced
this pull request
Oct 13, 2022
5 tasks
sodatea
approved these changes
Oct 14, 2022
sodatea
added
scope: types
❗ p4-important
This comment was marked as spam.
This comment was marked as spam.
|
@acidjazz We may need cautious to check if the change leads to some regressions, so please be patient. :) Downgrading |
Shinigami92
approved these changes
Oct 17, 2022
| @@ -1301,7 +1301,7 @@ export interface Events { | |||
| } | |||
|
|
|||
| type EventHandlers<E> = { | |||
| [K in keyof E]?: E[K] extends Function ? E[K] : (payload: E[K]) => void | |||
| [K in keyof E]?: E[K] extends (...args: any) => any ? E[K] : (payload: E[K]) => void | |||
There was a problem hiding this comment.
This is IMO a good change anyways as there is even a eslint rule to warn using Function at all
13 tasks
sodatea
removed
the
❗ p4-important
|
FYI the issue has been fixed in |
|
@sodatea I have 18.11.3 but the error is there. |
Closed
1 task
chrislone
pushed a commit
to chrislone/core
that referenced
this pull request
Feb 4, 2023
zhangzhonghe
pushed a commit
to zhangzhonghe/core
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: vuejs/language-tools#1985
With
@types/nodeversion >= 18.8.1,MouseEvent extends Functionis true, but with version <= 18.8.0MouseEvent extends Functionis false.Close #6899