Skip to content

fix(compiler-sfc): missing keywords of method property #6972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2022
Merged

fix(compiler-sfc): missing keywords of method property #6972

merged 2 commits into from
Nov 9, 2022
+21 −5

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Oct 27, 2022 •
edited
Loading

Before | After

closes #6971
add async or get keyword of method property in withDefaults.

@netlify
Copy link

netlify bot commented Oct 27, 2022 •
edited
Loading

❌ Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 6e558a1
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/636149d99a08120007eb5ce0

@sxzz sxzz marked this pull request as ready for review October 27, 2022 12:15
sxzz and others added 2 commits November 9, 2022 10:59
@sxzz @yyx990803
fix(compiler-sfc): missing keywords of method property

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
7cdff1d
@yyx990803
chore: resolve conflict
fc915b6
@yyx990803 yyx990803 merged commit 8a882ce into vuejs:main Nov 9, 2022
@sxzz sxzz deleted the fix/async-method branch November 9, 2022 03:13
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
@sxzz
fix(compiler-sfc): handle method shorthand syntax in withDefaults (vu…

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
f54f762 
…ejs#6972)

fix vuejs#6971
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this pull request Apr 12, 2023
@sxzz @zhangzhonghe
fix(compiler-sfc): handle method shorthand syntax in withDefaults (vu…

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
c24446d 
…ejs#6972)

fix vuejs#6971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing async keyword of object method
3 participants
@sxzz @antfu @yyx990803