chore: comment and order keywords in list alphabetically #7037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxzz
approved these changes
Nov 7, 2022
posva
changed the title
|
Actually, the comment is right and the implementation is wrong. |
sxzz
reviewed
Nov 14, 2022
| 'do,if,for,let,new,try,var,case,else,with,await,break,catch,class,const,' + | ||
| 'super,throw,while,yield,delete,export,import,return,switch,default,' + | ||
| 'extends,finally,continue,debugger,function,arguments,typeof,void' | ||
| 'arguments,await,break,case,catch,class,const,continue,debugger,default,' + |
There was a problem hiding this comment.
Can we change here to [...].join(',') for better readability?
chrislone
pushed a commit
to chrislone/core
that referenced
this pull request
Feb 4, 2023
zhangzhonghe
pushed a commit
to zhangzhonghe/core
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typeofis actually a prohibited keyword. There was a mistake in the comment. I just fix the comment and ordered the keywords so it's easier to read and identify this kind of error in the future.