Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change in 3.2.42 - immediate multiple watcher oldValue is undefined #7070

Closed
KaelWD opened this issue Nov 9, 2022 · 1 comment
Closed

Breaking change in 3.2.42 - immediate multiple watcher oldValue is undefined #7070

KaelWD opened this issue Nov 9, 2022 · 1 comment
Assignees
@LinusBorg
Labels
regression scope: reactivity

Comments

@KaelWD
Copy link
Contributor

KaelWD commented Nov 9, 2022

Vue version

3.2.42

Link to minimal reproduction

https://sfc.vuejs.org/#eNpNUEuugzAMvIqVTamUhj2iSO01SBd8TJuKfJSEskC5+3Pg/Ra2MvZ4MvbGbs6Jz4KsYnUYvHIRAsbFNdIo7ayPsIHHicPaxeEFCSZvNZxo4iQNQI7BmhChg2smFue/Uv+/lGPXKNqOQ//gULQG1xsHyneCrZ1HQpTvjzNcG9jyyKFlZxSzfRaZsqslTr6U1jiqLmIF0S8IiVp1eWxB/glE1G4mAiGAelSfpi5zzrzfHuPsWPWiOyfewRo6xv65/G4EyaofO5LR7hlL9orRhaoswzTkE76DsP5Z0kv4xUSlUWDQl97bNaAnYcl269Iklr4AGQN9KA==

Steps to reproduce

Open devtools

What is expected?

'a' is logged

What is actually happening?

TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))

System Info

No response

Any additional comments?

#5033
vuetifyjs/vuetify#16051

Typescript still says oldVal is [undefined, undefined]
@LinusBorg LinusBorg self-assigned this Nov 9, 2022
@LinusBorg
Copy link
Member

Sorry about that, will fix

@webfansplz webfansplz mentioned this issue Nov 9, 2022
Closed
@innocenzi innocenzi mentioned this issue Nov 9, 2022
Closed
@smarlhens smarlhens mentioned this issue Nov 9, 2022
Closed
chrislone pushed a commit to chrislone/core that referenced this issue Feb 4, 2023
@yyx990803
fix(watch): ensure oldValue in multi-source watcher is always an array
e06bc1e 
fix vuejs#7070
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this issue Apr 12, 2023
@yyx990803 @zhangzhonghe
fix(watch): ensure oldValue in multi-source watcher is always an array

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
45baec1 
fix vuejs#7070
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LinusBorg LinusBorg

Labels
regression scope: reactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(runtime-core): watching multiple values - handle undefined as initial values webfansplz/vue-next
2 participants
@LinusBorg @KaelWD