Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The type of props will be discard when using typed-macros #7111

Closed
sxzz opened this issue Nov 12, 2022 · 0 comments · Fixed by #7112
Closed

The type of props will be discard when using typed-macros #7111

sxzz opened this issue Nov 12, 2022 · 0 comments · Fixed by #7112
Labels
🔩 p2-edge-case

Comments

@sxzz
Copy link
Member

sxzz commented Nov 12, 2022

Vue version

3.2.45

Link to minimal reproduction

https://sfc.vuejs.org/#eNp9kcFugzAMQH/FyqVUKuGOgGnSPmAfkAsDQ6kgiZxADyj/PgdY1W1Sb7Fjv+c4q3i3Vi4zilwUrqHBehhr3ZfeVUo3RjsPLXb1PHoHJazQ6RySc1nBGiAoXWR7ExdzcAAc+tk+YYbJGvLcTNhBgI7MBCd2nmLT7rBkbBTcB3/9OHwJiweNn/GqWJUGlr9FO7B+MUOrdKiS84XBUsrHlOH8gzUjytH0yQbn7O9hPU52rD1yVGSPQFzEPm461VbenNG8mU2ujgunRA5bJub4GTFW4uq9dXmWua6J+7w5aajP+CRp1n6YUKKb0i8yd4fEYCUuT4yMkwtSSqhbJKRXzD+l/7gRy18TRPgGe2Snhw==

Steps to reproduce

  • Open the SFC Playground
  • Switch prod and dev mode

What is expected?

Under both prod and dev mode, props.fn is a function

What is actually happening?

In prod mode, props.fn is undefined, and in dev mode, props.fn is a function

System Info

No response

Any additional comments?

I'll make a PR to fix it.
@sxzz sxzz mentioned this issue Nov 12, 2022
Merged
yyx990803 pushed a commit that referenced this issue Nov 14, 2022
@sxzz
fix(compiler-sfc): always generate runtime prop type for Function (#7112
584eae6 
)

fix #7111
chrislone pushed a commit to chrislone/core that referenced this issue Feb 4, 2023
@sxzz
fix(compiler-sfc): always generate runtime prop type for Function (vu…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d014612 
…ejs#7112)

fix vuejs#7111
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this issue Apr 12, 2023
@sxzz @zhangzhonghe
fix(compiler-sfc): always generate runtime prop type for Function (vu…
a31578d 
…ejs#7112)

fix vuejs#7111
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🔩 p2-edge-case
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(compiler-sfc): never skip Function prop type
1 participant
@sxzz