Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): custom type props warning #7198

Merged
merged 4 commits into from Nov 25, 2022
Merged

fix(runtime-core): custom type props warning #7198

merged 4 commits into from Nov 25, 2022

Conversation

baiwusanyu-c
Copy link
Member

close: #7197

@netlify
Copy link

netlify bot commented Nov 23, 2022

❌ Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 96b4d76
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/637e124a19670100090c07cb

@LinusBorg
Copy link
Member

I added a test case.

@baiwusanyu-c
Copy link
Member Author

I added a test case.

Thank u 👍

@sxzz sxzz changed the title fix(runtime-core): Custom type props warning fix(runtime-core): custom type props warning Nov 25, 2022
@LinusBorg LinusBorg merged commit 620327d into vuejs:main Nov 25, 2022
@baiwusanyu-c baiwusanyu-c deleted the bwsy/fix/componentProp branch December 2, 2022 09:52
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
@baiwusanyu-c @LinusBorg
fix(runtime-core): ensure prop type validation warning shows custom c…
2db5eeb 
…lass names (vuejs#7198)

* fix(runtime-core): 

* fix(runtime-core): update

* fix(runtime-core): update reg

* test(runtime-core): add test case for warnings about prop type mismatches

Co-authored-by: Thorsten Luenborg <t.luenborg@googlemail.com>
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this pull request Apr 12, 2023
@baiwusanyu-c @LinusBorg @zhangzhonghe
fix(runtime-core): ensure prop type validation warning shows custom c…
699c1c1 
…lass names (vuejs#7198)

* fix(runtime-core): 

* fix(runtime-core): update

* fix(runtime-core): update reg

* test(runtime-core): add test case for warnings about prop type mismatches

Co-authored-by: Thorsten Luenborg <t.luenborg@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty type name in warning when expected prop type is a custom class
3 participants
@baiwusanyu-c @LinusBorg @sxzz