fix(types): allow undefined in StyleValue
#7954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuwu9145
added a commit
to yuwu9145/vue-next
that referenced
this pull request
Mar 25, 2023
yuwu9145
force-pushed
the
fix-sytleValue-type
branch
from
a5d5116
to
21690e4
Compare
yuwu9145
added a commit
to yuwu9145/vue-next
that referenced
this pull request
Mar 25, 2023
yuwu9145
force-pushed
the
fix-sytleValue-type
branch
from
21690e4
to
a791dd3
Compare
sxzz
changed the title
yuwu9145
added a commit
to yuwu9145/vue-next
that referenced
this pull request
Mar 26, 2023
yuwu9145
force-pushed
the
fix-sytleValue-type
branch
from
a791dd3
to
a001a20
Compare
sxzz
changed the title
StyleValue
sxzz
reviewed
Mar 28, 2023
packages/vue/jsx-runtime/dom.d.ts
Outdated
| @@ -234,7 +234,7 @@ interface AriaAttributes { | |||
| } | |||
|
|
|||
| // Vue's style normalization supports nested arrays | |||
| export type StyleValue = string | CSSProperties | Array<StyleValue> | |||
| export type StyleValue = undefined | string | CSSProperties | Array<StyleValue> | |||
There was a problem hiding this comment.
I think we can also support all the falsy value, like null, false
There was a problem hiding this comment.
Thanks, it makes sense.
But falsy value 0 should be excluded as it is also a number
Edit: it was just my personal opinion
sxzz
approved these changes
Mar 29, 2023
yuwu9145
force-pushed
the
fix-sytleValue-type
branch
from
6263cfd
to
924059d
Compare
antfu
added a commit
to vueuse/vueuse
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7955