Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(withDefaults): Allow to be used with generic defineProps #8335

Merged
merged 1 commit into from May 17, 2023
Merged

types(withDefaults): Allow to be used with generic defineProps #8335

merged 1 commit into from May 17, 2023

Conversation

pikax
Copy link
Member

@pikax pikax commented May 16, 2023 •
edited

fix #8310
fix #8331
fix #8325

Allow support for defineProps generics when using withDefaults.

There's a limitation to allows this to be smoother, default of generics are only allowed to be declared as ()=>T even if T is an native type

@yyx990803
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link

vue-bot commented May 17, 2023 •
edited

📝 Ran ecosystem CI: Open

suite result
naive-ui ❌ failure
nuxt ✅ success
pinia ✅ success
quasar ❌ failure
router ✅ success
test-utils ✅ success
vant ✅ success
vite-plugin-vue ✅ success
vitepress ✅ success
vue-macros ✅ success
vuetify ✅ success
vueuse ❌ failure
vue-simple-compiler ✅ success

@yyx990803
Copy link
Member

Ecosystem CI failures seem to be unrelated to this PR.

@yyx990803 yyx990803 merged commit 216f269 into main May 17, 2023
16 checks passed
@yyx990803 yyx990803 deleted the types_support_generic_on_withDefaults branch May 17, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: types
Projects
None yet
Milestone
No milestone
3 participants
@pikax @yyx990803 @vue-bot