perf: replace Map/Set with WeakMap/WeakSet #8549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TBR |
❌ Deploy Preview for vue-sfc-playground failed.
|
❌ Deploy Preview for vue-next-template-explorer failed.
|
Size ReportBundles
Usages
|
|
This PR solves the same problem as #7827, but I think #7827 should be preferred as it would also clean up deps that are primitive types (strings). But maybe the WeakMap approach is more perfomant? Not sure. either way the pros and cons should be weighted before merging this. Also, johnson seems to already have included the fix from #7827 in his larger reactivity refactor of #5912 according to #9419 (comment) |
LinusBorg
added
need discussion
and removed
ready to merge
|
@LinusBorg #7827 addresses memory leaks in reactivity. This PR aims to replace as many Maps in the project with WeakMaps as possible. It doesn't conflict with the code in #7827, and I believe WeakMap is the best solution for the in this PR. |
|
Okay, seems I was too quick here. Thanks for getting back to me quickly. :) |
LinusBorg
added
ready to merge
yyx990803
pushed a commit
that referenced
this pull request
Oct 21, 2023
lumozx
pushed a commit
to lumozx/core
that referenced
this pull request
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the keys of object properties, we should use
WeakMapandWeakSet, because they will not prevent the garbage collector from reclaiming the key.