Skip to content

fix(reactivity): onCleanup also needs to be cleaned #8655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 10, 2023
Merged

fix(reactivity): onCleanup also needs to be cleaned #8655

merged 3 commits into from
Nov 10, 2023
+37 −1

Conversation

shengxinjing
Copy link
Contributor

fix #7695 #5151

@shengxinjing
fix(reactivity): OnCleanup also needs to be cleaned

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5933176
@pandavips
Copy link

官方不是都已经禁用undefined了吗?
是不是意味着 undefined推荐用void替代

@shengxinjing
Copy link
Contributor Author

官方不是都已经禁用undefined了吗? 是不是意味着 undefined推荐用void替代

我跑lint和build没出啥问题

@shengxinjing
chore: undefined to void

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
bab625f
@sxzz sxzz added the ready for review This PR requires more reviews label Aug 21, 2023
@shengxinjing @yyx990803
chore: void to undefined

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b6a39f5 
Co-authored-by: Evan You <yyx990803@gmail.com>
@github-actions
Copy link

github-actions bot commented Sep 3, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 85.9 kB (+18 B) 32.7 kB (+12 B) 29.4 kB (-26 B)
vue.global.prod.js 132 kB (+18 B) 49.3 kB (+7 B) 44.3 kB (+13 B)

Usages

Name Size Gzip Brotli
createApp 47.9 kB (+18 B) 18.9 kB (+8 B) 17.2 kB (+4 B)
createSSRApp 50.7 kB (+18 B) 20 kB (+7 B) 18.2 kB (+4 B)
defineCustomElement 50.3 kB (+18 B) 19.6 kB (+6 B) 17.9 kB (+6 B)
overall 61.3 kB (+18 B) 23.7 kB (+9 B) 21.5 kB (-35 B)

@pikax pikax added ready for review This PR requires more reviews ready to merge The PR is ready to be merged. and removed ready for review This PR requires more reviews wait changes labels Oct 20, 2023
@yyx990803 yyx990803 merged commit 73fd810 into vuejs:main Nov 10, 2023
@shengxinjing shengxinjing deleted the reactivity-oncleanup-clear branch November 10, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803

@sxzz sxzz

Assignees
No one assigned
Labels
ready to merge The PR is ready to be merged.
Projects
Issue / PR Management
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abnormal result when register onCleanup conditionally
5 participants
@shengxinjing @pandavips @yyx990803 @sxzz @pikax