types: export type AriaAttributes #8909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxzz
reviewed
Aug 3, 2023
| @@ -46,7 +46,7 @@ type Booleanish = boolean | 'true' | 'false' | |||
| type Numberish = number | string | |||
|
|
|||
| // All the WAI-ARIA 1.1 attributes from https://www.w3.org/TR/wai-aria-1.1/ | |||
| interface AriaAttributes { | |||
| export interface AriaAttributes { | |||
There was a problem hiding this comment.
because i need types i will use in Oku / primitives Also, this is exported on the react.
There was a problem hiding this comment.
@productdevbook Why you need it? 🤔🤔🤔
There was a problem hiding this comment.
The last place you showed. Core developers always need this data.
sxzz
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, my first vue pr :D