Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): prevent template from being cached between apps with different options #9724

Merged
merged 1 commit into from Dec 4, 2023
Merged

fix(app): prevent template from being cached between apps with different options #9724

merged 1 commit into from Dec 4, 2023

Conversation

pikax
Copy link
Member

@pikax pikax commented Nov 30, 2023

closes #9618

create multiple template caches depending on app options

@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.7 kB 33 kB 29.8 kB
vue.global.prod.js 133 kB (+92 B) 49.8 kB (+31 B) 44.7 kB (+31 B)

Usages

Name Size Gzip Brotli
createApp 48.2 kB 19 kB 17.4 kB
createSSRApp 51.5 kB 20.3 kB 18.5 kB
defineCustomElement 50.6 kB 19.7 kB 18 kB
overall 61.6 kB 23.8 kB 21.7 kB

@pikax pikax added scope: compiler 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Nov 30, 2023
@pikax pikax mentioned this pull request Nov 30, 2023
Merged
@yyx990803 yyx990803 merged commit ec71585 into main Dec 4, 2023
15 checks passed
@yyx990803 yyx990803 deleted the pikax/use_app_options_as_cache branch December 4, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

First created app's config.compilerOptions applies to all later apps
2 participants
@pikax @yyx990803