From b13089f419adcb32ba9d758d5f2a01604a098c87 Mon Sep 17 00:00:00 2001 From: Haoqun Jiang Date: Fri, 12 May 2023 15:53:29 +0800 Subject: [PATCH] fix: use `--build` for type-checking to be exaustive and less-fragile Fixes #267 Thanks @segevfiner for noticing this new feature! Currently there's still a small annoyance that `vue-tsc` would output an extra error message when there're type errors in `.vue` files https://github.com/vuejs/language-tools/issues/2622 But it works well if there's no error. I've already submitted a PR to address it https://github.com/vuejs/language-tools/pull/3176 --- template/base/_gitignore | 2 ++ template/config/typescript/package.json | 2 +- template/tsconfig/base/tsconfig.app.json | 1 + template/tsconfig/base/tsconfig.node.json | 1 + template/tsconfig/cypress-ct/package.json | 5 ----- template/tsconfig/vitest/package.json | 3 --- 6 files changed, 5 insertions(+), 9 deletions(-) delete mode 100644 template/tsconfig/cypress-ct/package.json diff --git a/template/base/_gitignore b/template/base/_gitignore index 38adffa6..8ee54e8d 100644 --- a/template/base/_gitignore +++ b/template/base/_gitignore @@ -26,3 +26,5 @@ coverage *.njsproj *.sln *.sw? + +*.tsbuildinfo diff --git a/template/config/typescript/package.json b/template/config/typescript/package.json index 69a087b3..e8b7bc1f 100644 --- a/template/config/typescript/package.json +++ b/template/config/typescript/package.json @@ -2,7 +2,7 @@ "scripts": { "build": "run-p type-check build-only", "build-only": "vite build", - "type-check": "vue-tsc --noEmit" + "type-check": "vue-tsc --build" }, "devDependencies": { "@types/node": "^18.16.3", diff --git a/template/tsconfig/base/tsconfig.app.json b/template/tsconfig/base/tsconfig.app.json index 3e5b621e..491e0939 100644 --- a/template/tsconfig/base/tsconfig.app.json +++ b/template/tsconfig/base/tsconfig.app.json @@ -4,6 +4,7 @@ "exclude": ["src/**/__tests__/*"], "compilerOptions": { "composite": true, + "noEmit": true, "baseUrl": ".", "paths": { "@/*": ["./src/*"] diff --git a/template/tsconfig/base/tsconfig.node.json b/template/tsconfig/base/tsconfig.node.json index a52f76f3..b0078fa7 100644 --- a/template/tsconfig/base/tsconfig.node.json +++ b/template/tsconfig/base/tsconfig.node.json @@ -3,6 +3,7 @@ "include": ["vite.config.*", "vitest.config.*", "cypress.config.*", "playwright.config.*"], "compilerOptions": { "composite": true, + "noEmit": true, "module": "ESNext", "types": ["node"] } diff --git a/template/tsconfig/cypress-ct/package.json b/template/tsconfig/cypress-ct/package.json deleted file mode 100644 index ba3c34a4..00000000 --- a/template/tsconfig/cypress-ct/package.json +++ /dev/null @@ -1,5 +0,0 @@ -{ - "scripts": { - "type-check": "vue-tsc --noEmit -p tsconfig.cypress-ct.json --composite false" - } -} diff --git a/template/tsconfig/vitest/package.json b/template/tsconfig/vitest/package.json index c91681fa..0911662b 100644 --- a/template/tsconfig/vitest/package.json +++ b/template/tsconfig/vitest/package.json @@ -1,7 +1,4 @@ { - "scripts": { - "type-check": "vue-tsc --noEmit -p tsconfig.vitest.json --composite false" - }, "devDependencies": { "@types/jsdom": "^21.1.1" }